Fix miniapp bottom padding with platform detection#610
Merged
realproject7 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Use usePlatformDetection() hook instead of env(safe-area-inset-bottom) for miniapp environments where CSS environment variables return 0. When isMiniApp is true, apply explicit Tailwind padding (pb-8/pb-10). Regular browser and desktop layouts use the existing safe-area-inset fallback. Applied to MobileActionBar (fixed bar + bottom sheet) and ReadingMode bottom nav. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 27, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR replaces the ineffective env-based miniapp padding with the existing platform-detection hook and applies explicit bottom padding to the exact fixed-bottom elements called out in issue #608.
Findings
- None.
Decision
Approved because the change matches issue #608, stays tightly scoped to the affected components, and preserves regular browser and desktop behavior by only adding the extra padding when isMiniApp is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #608
usePlatformDetection()hook to detect miniapp environments instead of relying onenv(safe-area-inset-bottom)which returns 0 in Farcaster/Base webviewspb-8whenisMiniApp, else existing safe-area paddingpb-10whenisMiniApp, else existing safe-area paddingpb-8whenisMiniApp, else existing safe-area paddingTest plan
🤖 Generated with Claude Code